Skip reloading a tab on service worker update if the user is in the middle of something

docs/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Next
 
 * Fix a bug in Chrome for Android 134 and newer where the space reserved for the virtual keyboard would not be reclaimed after the keyboard is dismissed.
+* When you update DIM, it will no longer reload other tabs if you have a sheet up or are on the Loadout Optimizer. DIM may fail to load some pages until you refresh, though.
 
 ## 8.63.0 <span class="changelog-date">(2025-03-16)</span>
 

src/app/dim-ui/AutoRefresh.tsx

@@ -10,7 +10,7 @@ import { useLocation } from 'react-router';
 import { isDragging$ } from '../inventory/drag-events';
 import { loadingTracker } from '../shell/loading-tracker';
 import { refresh$, refresh as triggerRefresh } from '../shell/refresh-events';
-import { sheetsOpen } from './Sheet';
+import { sheetsOpen } from './sheets-open';
 
 const globalSettingsSelector = (state: RootState) => state.dimApi.globalSettings;
 
@@ -197,7 +197,7 @@ function useVisibilityRefresh() {
         // Loadout optimizer is all about state, don't reload it
         !onOptimizerPage &&
         // If a sheet is up, the user is doing something. We check sheetsOpen here, because it is not reactive!
-        sheetsOpen <= 0
+        sheetsOpen.open <= 0
       ) {
         // Sneaky updates - if DIM is hidden and needs an update, do the update.
         reloadDIM();

src/app/dim-ui/Sheet.tsx

@@ -25,6 +25,7 @@ import { AppIcon, disabledIcon } from '../shell/icons';
 import ErrorBoundary from './ErrorBoundary';
 import { PressTipRoot } from './PressTip';
 import styles from './Sheet.m.scss';
+import { sheetsOpen } from './sheets-open';
 import { useFixOverscrollBehavior } from './useFixOverscrollBehavior';
 
 /**
@@ -92,12 +93,6 @@ function useDisableParent(
   return [effectivelyDisabled, setDisabledByChildSheet];
 }
 
-/**
- * The total number of sheets that are open. Used by the sneaky updates code to
- * determine if the user is in the middle of something.
- */
-export let sheetsOpen = 0;
-
 /**
  * A Sheet is a UI element that comes up from the bottom of the screen,
  * and can be dragged downward to dismiss
@@ -247,9 +242,9 @@ export default function Sheet({
 
   // Track the total number of sheets that are open (to help prevent reloads while users are doing things)
   useEffect(() => {
-    sheetsOpen++;
+    sheetsOpen.open++;
     return () => {
-      sheetsOpen--;
+      sheetsOpen.open--;
     };
   }, []);
 

src/app/dim-ui/sheets-open.ts

@@ -0,0 +1,10 @@
+/**
+ * The total number of sheets that are open. Used by the sneaky updates code to
+ * determine if the user is in the middle of something.
+ *
+ * This is in a separate file from Sheet.tsx to avoid pulling in dependencies to
+ * tests.
+ */
+export const sheetsOpen = {
+  open: 0,
+};

src/app/register-service-worker.ts

@@ -1,5 +1,6 @@
 import { getClient } from '@sentry/browser';
 import { toHttpStatusError } from './bungie-api/http-client';
+import { sheetsOpen } from './dim-ui/sheets-open';
 import { errorLog, infoLog, warnLog } from './utils/log';
 import { Observable } from './utils/observable';
 import { delay } from './utils/promises';
@@ -89,7 +90,16 @@ export default function registerServiceWorker() {
                     return;
                   }
                   preventDevToolsReloadLoop = true;
-                  window.location.reload();
+                  if (
+                    // Loadout optimizer is all about state, don't reload it
+                    !window.location.pathname.endsWith('/optimizer') &&
+                    // If a sheet is up, the user is doing something. We check sheetsOpen here, because it is not reactive!
+                    sheetsOpen.open <= 0
+                  ) {
+                    window.location.reload();
+                  } else {
+                    warnLog(TAG, 'Not reloading because user is in the middle of something');
+                  }
                 });
               } else if ($featureFlags.debugSW) {
                 // At this point, everything has been precached.