Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip reloading a tab on service worker update if the user is in the middle of something #10996

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Mar 18, 2025

May fix #10761, with the downside that DIM may be "broken" (e.g. fail to load pages) until reloaded by the user. Our automatic reloads on navigation still happen though, so it's likely they'll still get updated before that.

@bhollis bhollis requested a review from chainrez March 18, 2025 05:44
@bhollis bhollis merged commit ff28f3f into master Mar 19, 2025
7 checks passed
@bhollis bhollis deleted the prevent-reload branch March 19, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't refresh the page when there are unsaved changes!
1 participant