Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix Clearer Water and Old Water issues with incorrect foliage/grass colors in modern biomes, missing surface opacity, and some biomes lacking Clearer Water #520

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

PAPISOP
Copy link
Member

@PAPISOP PAPISOP commented Feb 12, 2025

  1. Added minecraft:foliage_appearance and minecraft:grass_appearance components from the vanilla files which fixes modern biomes having wrong foliage and grass color
  2. Added surface_opacity field to minecraft:water_appearance component from the vanilla files which fixes there is no surface opacity of water from the outside
  3. Added all the client biome files which uses minecraft:fog_default as they were skipped before and added bt:fog_default fog in Clearer Water and old_clearer_water combination

Resolves #492

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

…and grass color being wrong color in modern biomes, fix a bug where there is no surface opacity of water from the outside and fix some biomes didn't have Clearer Water

1. Added `minecraft:foliage_appearance` and `minecraft:grass_appearance` components from the vanilla files which fixes modern biomes having wrong foliage and grass color
2. Added `surface_opacity` field to `minecraft:water_appearance` component from the vanilla files which fixes there is no surface opacity of water from the outside
3. Added all the client biome files which uses `minecraft:fog_default` as they were skipped before and added `bt:fog_default` fog in Clearer Water and old_clearer_water combination
@PAPISOP PAPISOP requested a review from drav0011 February 12, 2025 09:30
@PAPISOP PAPISOP changed the title fix(files): Fix Clearer Water and Old Water have issues with foliage and grass color being wrong color in modern biomes, fix a bug where there is no surface opacity of water from the outside and fix some biomes didn't have Clearer Water fix(files): Fix Clearer Water and Old Water issues with incorrect foliage/grass colors in modern biomes, missing surface opacity, and some biomes lacking Clearer Water Feb 12, 2025
@drav0011 drav0011 merged commit 4d41ac7 into BedrockTweaks:devel Feb 13, 2025
@PAPISOP PAPISOP added the resource_packs Indicates the issue is related to Resource Packs label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource_packs Indicates the issue is related to Resource Packs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Terrain] Clearer Water
2 participants