Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): Lush Grass All 'Round now gives modern biomes like cherry grove, pale garden, etc a lush green colormap #521

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

PAPISOP
Copy link
Member

@PAPISOP PAPISOP commented Feb 12, 2025

First review #520 before reviewing this

  1. Renamed Lush Grass (Mostly) All 'Round! to Lush Grass All 'Round! while also removing the warning message and editing the description
  2. Lush Grass All 'Round! will now work in modern biomes like cherry grove, pale garden, etc thanks to minecraft:foliage_appearance and minecraft:grass_appearance components in client biome files
  3. Added lush_grass_clearer_water, lush_grass_old_water and lush_grass_old_clearer_water combinations

By checking the following boxes with an X, you ensure that:

  • The pack was tested ingame in at least one device.

  • The pack is an existing BT pack, is a missing pack from VT or is an accepted pack/change in a discussion.

  • The pack code follows the style guide.

  • The commits follow the contribution guidelines.

  • The PR follows the contribution guidelines.

  • (Optional) Tested in Windows

  • (Optional) Tested in Android

  • (Optional) Tested in iOS

  • (Optional) Tested in any console

  • (Optional) Tested in BDS

…s like cherry grove, pale garden, etc to have lush green colormap

1. Renamed Lush Grass (Mostly) All 'Round! to Lush Grass All 'Round! while also removing the warning message and editing the description
2. Lush Grass All 'Round! will now work in modern biomes like cherry grove, pale garden, etc thanks to `minecraft:foliage_appearance` and `minecraft:grass_appearance` components in client biome files
3. Added `lush_grass_clearer_water`, `lush_grass_old_water` and `lush_grass_old_clearer_water` combinations
@PAPISOP PAPISOP requested a review from drav0011 February 12, 2025 09:30
@PAPISOP PAPISOP changed the title feat(files): Lush Grass All 'Round will now make all the modern biomes like cherry grove, pale garden, etc to have lush green colormap feat(files): Lush Grass All 'Round now gives modern biomes like cherry grove, pale garden, etc a lush green colormap Feb 12, 2025
@drav0011 drav0011 merged commit 0f65f9b into BedrockTweaks:devel Feb 13, 2025
@PAPISOP PAPISOP added the resource_packs Indicates the issue is related to Resource Packs label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource_packs Indicates the issue is related to Resource Packs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants