-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: child modules telemetry check #4370
Open
ReneHezser
wants to merge
30
commits into
Azure:main
Choose a base branch
from
ReneHezser:child-modules-telemetry-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,154
−1,010
Open
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
375a183
add child modules
ReneHezser 54ce808
- initial child modules don't need to bump the parent
ReneHezser 40fe96d
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 9590175
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser aa67fb6
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 5dcf3f5
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 0949f88
Update utilities/pipelines/staticValidation/compliance/module.tests.ps1
ReneHezser 257510b
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 83272f8
simplify and cleanup
ReneHezser d26bfe1
cleanup
ReneHezser 9e19743
cleanup
ReneHezser dae48f6
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 473ee35
generate an error instead of a warning
ReneHezser a5d1d17
changed logic to use variable
ReneHezser ab04d15
telemetry tests adjusted for published modules and not only toplevel
ReneHezser 541a50f
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 5b801d0
updates
ReneHezser fe1e40b
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 34f6232
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 7881784
Merge branch 'main' into child-modules-telemetry-check
ReneHezser b3f1806
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 1db3d87
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 4cc2725
Merge branch 'Azure:main' into child-modules-telemetry-check
ReneHezser 562ee04
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 1307c58
updated res modules to pass test
ReneHezser 1183e87
fixed web site
ReneHezser e21913b
Merge branch 'main' into child-modules-telemetry-check
ReneHezser 61fd032
Update utilities/pipelines/staticValidation/compliance/module.tests.ps1
ReneHezser 8aba717
cleanup
ReneHezser d35f9c4
Merge branch 'main' into child-modules-telemetry-check
ReneHezser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment regarding workflows
To remidiate
avm.res.network.virtual-network
would run if you pull latest upstream. The module is not orhpaned anymoreavm.res.document-db.database-account
failed due to transient errorFor Info
elastic-san/elastic-san
fails due to a bug in theIf a UDT definition [managedIdentitiesType] exists and supports system-assigned-identities, the template should have an output for its principal ID.
test. This is not caused by your changes, but I found it worth pointing out as this was not tracked (- created PR fix: Fixed MSI UDT test to only check for the required output if the imported type is also used by a parameter #4498)azd/apim-api
failed due to the module using\n
as a line-ending, but your local devise used\r\n
. This is already an issue in main and not related to your code. But it's an interesting takeaway - presumably caused by a contributor on Linux/Mac.