-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: child modules telemetry check #4370
base: main
Are you sure you want to change the base?
Conversation
- referenced child modules should have the telemetry disabled
utilities/pipelines/sharedScripts/helper/Get-CrossReferencedModuleList.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/staticValidation/compliance/module.tests.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/staticValidation/compliance/module.tests.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/staticValidation/compliance/module.tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to run the static validation step only on the whole library before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. No red pipeline is a result of this PR. I've updated all res modules to fulfill the new spec.
Hey @ReneHezser, just added one ask as a comment and resolved the rest. Looks legit. 💪 |
Hey @ReneHezser,
|
utilities/pipelines/staticValidation/compliance/module.tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment regarding workflows
To remidiate
avm.res.network.virtual-network
would run if you pull latest upstream. The module is not orhpaned anymoreavm.res.document-db.database-account
failed due to transient error
For Info
elastic-san/elastic-san
fails due to a bug in theIf a UDT definition [managedIdentitiesType] exists and supports system-assigned-identities, the template should have an output for its principal ID.
test. This is not caused by your changes, but I found it worth pointing out as this was not tracked (- created PR fix: Fixed MSI UDT test to only check for the required output if the imported type is also used by a parameter #4498)azd/apim-api
failed due to the module using\n
as a line-ending, but your local devise used\r\n
. This is already an issue in main and not related to your code. But it's an interesting takeaway - presumably caused by a contributor on Linux/Mac.
Description
Child modules should be references with telemetry disabled. A static test checks that and lists the affected resources.
Depends on Cross referenced Modules
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.