Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed duplicated resource from PE type #4154

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion avm/utl/types/avm-common-types/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ param privateEndpointMultiService privateEndpointMultiServiceType[] = [
]
}
privateLinkServiceConnectionName: 'myConnection'
resourceGroupName: 'myResourceGroup'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
Expand Down
6 changes: 0 additions & 6 deletions avm/utl/types/avm-common-types/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,6 @@ type privateEndpointSingleServiceType = {

@description('Optional. Enable/Disable usage telemetry for module.')
enableTelemetry: bool?

@description('Optional. Specify if you want to deploy the Private Endpoint into a different Resource Group than the main resource.')
resourceGroupName: string?
}

@export()
Expand Down Expand Up @@ -358,9 +355,6 @@ type privateEndpointMultiServiceType = {

@description('Optional. Enable/Disable usage telemetry for module.')
enableTelemetry: bool?

@description('Optional. Specify if you want to deploy the Private Endpoint into a different resource group than the main resource.')
resourceGroupName: string?
}

// ======================== //
Expand Down
16 changes: 1 addition & 15 deletions avm/utl/types/avm-common-types/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.32.4.45862",
"templateHash": "14999467792384745276"
"templateHash": "9152524058851826986"
},
"name": "Default interface types for AVM modules",
"description": "This module provides you with all common variants for AVM interfaces to be used in AVM modules.\n\nDetails for how to implement these interfaces can be found in the AVM documentation [here](https://azure.github.io/Azure-Verified-Modules/specs/bcp/res/interfaces/).\n",
Expand Down Expand Up @@ -704,13 +704,6 @@
"metadata": {
"description": "Optional. Enable/Disable usage telemetry for module."
}
},
"resourceGroupName": {
"type": "string",
"nullable": true,
"metadata": {
"description": "Optional. Specify if you want to deploy the Private Endpoint into a different Resource Group than the main resource."
}
}
},
"metadata": {
Expand Down Expand Up @@ -850,13 +843,6 @@
"metadata": {
"description": "Optional. Enable/Disable usage telemetry for module."
}
},
"resourceGroupName": {
"type": "string",
"nullable": true,
"metadata": {
"description": "Optional. Specify if you want to deploy the Private Endpoint into a different resource group than the main resource."
}
}
},
"metadata": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ param privateEndpointMultiService privateEndpointMultiServiceType[] = [
]
}
privateLinkServiceConnectionName: 'myConnection'
resourceGroupName: 'myResourceGroup'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
Expand Down
Loading