Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed duplicated resource from PE type #4154

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 14, 2025

Description

When introducing the resourceGroupResourceId property, the resourceGroupName property was not removed from the privateEndpointMultiServiceType and privateEndpointSingleServiceType types.

Pipeline Reference

Pipeline
avm.utl.types.avm-common-types

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jan 14, 2025
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Jan 14, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 14, 2025
@AlexanderSehr AlexanderSehr marked this pull request as ready for review January 14, 2025 12:29
@AlexanderSehr AlexanderSehr requested review from a team as code owners January 14, 2025 12:29
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 14, 2025 12:29
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jan 14, 2025
Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderSehr AlexanderSehr merged commit f934be4 into main Jan 14, 2025
25 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/avmPESpecRGDuplicationFix branch January 14, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants