feat: New module avm/res/cache/redis-enterprise - Redis Enterprise and Azure Managed Redis (Preview)
#4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avm-team-linter
bot
added
the
Needs: Core Team 🧞
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
2 tasks
JeffreyCA
force-pushed
the
cache/redis-enterprise
branch
3 times, most recently
from
c100ac5 to
9e7eb8d
Compare
avm/res/cache/redis-enterprise/tests/e2e/kv-secrets/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/amr-entra-id/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/dependencies2.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Create work @JeffreyCA, not much to call out :) Let me know if you have any questions regarding the comments.
If you addressed any please just comment them as such and I'll resolve them after a re-review.
Also, if you need help with the CI, let me know.
avm/res/cache/redis-enterprise/database/access-policy-assignment/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/active-geo-replication/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/amr-entra-id/dependencies.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/database/access-policy-assignment/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/kv-secrets/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/cache/redis-enterprise/tests/e2e/defaults/main.test.bicep
Outdated
Show resolved
Hide resolved
JeffreyCA
force-pushed
the
cache/redis-enterprise
branch
from
4b56325 to
275dca7
Compare
|
Tests pass with latest changes:
|
AlexanderSehr
approved these changes
Feb 19, 2025
anderseide
pushed a commit
to anderseide/avm-bicep-registry-modules
that referenced
this pull request
Feb 19, 2025
…and Azure Managed Redis (Preview) (Azure#4114) ## Description Initial implementation of Bicep AVM for Redis Enterprise and Azure Managed Redis (Preview) caches (`Microsoft.Cache/redisEnterprise`). There is a related module, [`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis), that covers `Microsoft.Cache/redis`: | Module Name | Resource Type | SKUs | |----------------------------|--------------------------------|--------------------------------------------------------------------------------------------| | [`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis) | Microsoft.Cache/redis | **OSS Redis:** Basic, Standard, Premium | | `avm/res/cache/redis-enterprise` (this PR) | Microsoft.Cache/redisEnterprise | **Redis Enterprise:** Enterprise, Enterprise Flash<br>**Azure Managed Redis (Preview):** Balanced, Compute Optimized, Flash Optimized, Memory Optimized |  Closes Azure/Azure-Verified-Modules#1731. ## Pipeline Reference I'm facing issues setting up CI on my fork using my Azure subscription and Service Principal in the Microsoft tenant, but was able to validate all the E2E tests passed using [`Test-ModuleLocally.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Test-ModuleLocally.ps1).  <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
anderseide
pushed a commit
to anderseide/avm-bicep-registry-modules
that referenced
this pull request
Feb 23, 2025
…and Azure Managed Redis (Preview) (Azure#4114) ## Description Initial implementation of Bicep AVM for Redis Enterprise and Azure Managed Redis (Preview) caches (`Microsoft.Cache/redisEnterprise`). There is a related module, [`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis), that covers `Microsoft.Cache/redis`: | Module Name | Resource Type | SKUs | |----------------------------|--------------------------------|--------------------------------------------------------------------------------------------| | [`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis) | Microsoft.Cache/redis | **OSS Redis:** Basic, Standard, Premium | | `avm/res/cache/redis-enterprise` (this PR) | Microsoft.Cache/redisEnterprise | **Redis Enterprise:** Enterprise, Enterprise Flash<br>**Azure Managed Redis (Preview):** Balanced, Compute Optimized, Flash Optimized, Memory Optimized |  Closes Azure/Azure-Verified-Modules#1731. ## Pipeline Reference I'm facing issues setting up CI on my fork using my Azure subscription and Service Principal in the Microsoft tenant, but was able to validate all the E2E tests passed using [`Test-ModuleLocally.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Test-ModuleLocally.ps1).  <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of Bicep AVM for Redis Enterprise and Azure Managed Redis (Preview) caches (
Microsoft.Cache/redisEnterprise).There is a related module,
avm/res/cache/redis, that coversMicrosoft.Cache/redis:avm/res/cache/redisavm/res/cache/redis-enterprise(this PR)Azure Managed Redis (Preview): Balanced, Compute Optimized, Flash Optimized, Memory Optimized
Closes Azure/Azure-Verified-Modules#1731.
Pipeline Reference
I'm facing issues setting up CI on my fork using my Azure subscription and Service Principal in the Microsoft tenant, but was able to validate all the E2E tests passed using
Test-ModuleLocally.ps1.Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.