Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/cache/redis-enterprise #1731

Closed
2 tasks done
JeffreyCA opened this issue Nov 22, 2024 · 9 comments · Fixed by Azure/bicep-registry-modules#4114
Closed
2 tasks done

[Module Proposal]: avm/res/cache/redis-enterprise #1731

JeffreyCA opened this issue Nov 22, 2024 · 9 comments · Fixed by Azure/bicep-registry-modules#4114
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@JeffreyCA
Copy link

JeffreyCA commented Nov 22, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/cache/redis-enterprise

Module Details

There is a similar avm/res/cache/redis module, but it only but only covers Microsoft.Cache/redis resources (Basic, Standard, and Premium tiers).

Resource type: Microsoft.Cache/redisEnterprise

https://learn.microsoft.com/en-us/azure/templates/microsoft.cache/redisenterprise?pivots=deployment-language-bicep
https://learn.microsoft.com/en-us/rest/api/redis/redisenterprisecache/operation-groups?view=rest-redis-redisenterprisecache-2024-10-01

This would bring support for the Enterprise and Enterprise Flash tiers (pricing table) and the just announced Azure Managed Redis offerings (Memory Optimized, Balanced, Compute Optimized, and Flash Optimized tiers) (pricing table) since they both use the same resource provider and resource type.

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

JeffreyCA

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@JeffreyCA JeffreyCA added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Nov 22, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module labels Nov 27, 2024
@matebarabas
Copy link
Contributor

Hi @@JeffreyCA,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Dec 10, 2024
@matebarabas matebarabas added Status: Owners Identified 🤘 This module has its owners identified and removed Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Dec 10, 2024
@JeffreyCA
Copy link
Author

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Dec 10, 2024
@matebarabas
Copy link
Contributor

Hi @JeffreyCA,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas
Copy link
Contributor

Resource reference: https://learn.microsoft.com/en-us/azure/templates/microsoft.cache/2024-10-01/redisenterprise?pivots=deployment-language-bicep

@JeffreyCA
Copy link
Author

Hi @JeffreyCA,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:

    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:

    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

The module is ready for review. Here is the PR: Azure/bicep-registry-modules#4114

@matebarabas matebarabas added Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Jan 6, 2025
@matebarabas matebarabas moved this from Proposed to In Review in AVM - Module Triage Jan 6, 2025
@JeffreyCA
Copy link
Author

Important

@JeffreyCA, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Jan 27, 2025

Important

@JeffreyCA, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

AlexanderSehr pushed a commit to Azure/bicep-registry-modules that referenced this issue Feb 19, 2025
…and Azure Managed Redis (Preview) (#4114)

## Description

Initial implementation of Bicep AVM for Redis Enterprise and Azure
Managed Redis (Preview) caches (`Microsoft.Cache/redisEnterprise`).

There is a related module,
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis),
that covers `Microsoft.Cache/redis`:

| Module Name | Resource Type | SKUs |

|----------------------------|--------------------------------|--------------------------------------------------------------------------------------------|
|
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis)
| Microsoft.Cache/redis | **OSS Redis:** Basic, Standard, Premium |
| `avm/res/cache/redis-enterprise` (this PR) |
Microsoft.Cache/redisEnterprise | **Redis Enterprise:** Enterprise,
Enterprise Flash<br>**Azure Managed Redis (Preview):** Balanced, Compute
Optimized, Flash Optimized, Memory Optimized |


![image](https://github.com/user-attachments/assets/7128fcea-0708-4ae5-b2ed-8e1e1b9dd6ff)

Closes Azure/Azure-Verified-Modules#1731.

## Pipeline Reference

I'm facing issues setting up CI on my fork using my Azure subscription
and Service Principal in the Microsoft tenant, but was able to validate
all the E2E tests passed using
[`Test-ModuleLocally.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Test-ModuleLocally.ps1).


![image](https://github.com/user-attachments/assets/9a8de7d8-598e-41b0-8ebc-3ae68ceb697b)

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@github-project-automation github-project-automation bot moved this from In Review to Done in AVM - Module Triage Feb 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Feb 19, 2025
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.
  • Issue template file updated.

The module index will be updated to reflect this change.

Thank you for your work @JeffreyCA!

@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Feb 19, 2025
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this issue Feb 19, 2025
…and Azure Managed Redis (Preview) (Azure#4114)

## Description

Initial implementation of Bicep AVM for Redis Enterprise and Azure
Managed Redis (Preview) caches (`Microsoft.Cache/redisEnterprise`).

There is a related module,
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis),
that covers `Microsoft.Cache/redis`:

| Module Name | Resource Type | SKUs |

|----------------------------|--------------------------------|--------------------------------------------------------------------------------------------|
|
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis)
| Microsoft.Cache/redis | **OSS Redis:** Basic, Standard, Premium |
| `avm/res/cache/redis-enterprise` (this PR) |
Microsoft.Cache/redisEnterprise | **Redis Enterprise:** Enterprise,
Enterprise Flash<br>**Azure Managed Redis (Preview):** Balanced, Compute
Optimized, Flash Optimized, Memory Optimized |


![image](https://github.com/user-attachments/assets/7128fcea-0708-4ae5-b2ed-8e1e1b9dd6ff)

Closes Azure/Azure-Verified-Modules#1731.

## Pipeline Reference

I'm facing issues setting up CI on my fork using my Azure subscription
and Service Principal in the Microsoft tenant, but was able to validate
all the E2E tests passed using
[`Test-ModuleLocally.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Test-ModuleLocally.ps1).


![image](https://github.com/user-attachments/assets/9a8de7d8-598e-41b0-8ebc-3ae68ceb697b)

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this issue Feb 23, 2025
…and Azure Managed Redis (Preview) (Azure#4114)

## Description

Initial implementation of Bicep AVM for Redis Enterprise and Azure
Managed Redis (Preview) caches (`Microsoft.Cache/redisEnterprise`).

There is a related module,
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis),
that covers `Microsoft.Cache/redis`:

| Module Name | Resource Type | SKUs |

|----------------------------|--------------------------------|--------------------------------------------------------------------------------------------|
|
[`avm/res/cache/redis`](https://github.com/Azure/bicep-registry-modules/tree/main/avm/res/cache/redis)
| Microsoft.Cache/redis | **OSS Redis:** Basic, Standard, Premium |
| `avm/res/cache/redis-enterprise` (this PR) |
Microsoft.Cache/redisEnterprise | **Redis Enterprise:** Enterprise,
Enterprise Flash<br>**Azure Managed Redis (Preview):** Balanced, Compute
Optimized, Flash Optimized, Memory Optimized |


![image](https://github.com/user-attachments/assets/7128fcea-0708-4ae5-b2ed-8e1e1b9dd6ff)

Closes Azure/Azure-Verified-Modules#1731.

## Pipeline Reference

I'm facing issues setting up CI on my fork using my Azure subscription
and Service Principal in the Microsoft tenant, but was able to validate
all the E2E tests passed using
[`Test-ModuleLocally.ps1`](https://github.com/Azure/bicep-registry-modules/blob/main/utilities/tools/Test-ModuleLocally.ps1).


![image](https://github.com/user-attachments/assets/9a8de7d8-598e-41b0-8ebc-3ae68ceb697b)

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|          |

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
2 participants