Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web/static-site workflow fix & update to enforce publish with source #1253

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Mar 12, 2024

Description

  • Update template to enforce publish with source
  • Fix bug in workflow trigger

Pipeline Reference

Pipeline
avm.res.web.static-site

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@eriqua eriqua self-assigned this Mar 12, 2024
@eriqua eriqua requested review from a team as code owners March 12, 2024 11:33
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 12, 2024
@eriqua eriqua enabled auto-merge (squash) March 12, 2024 11:50
@eriqua eriqua disabled auto-merge March 12, 2024 11:57
@eriqua eriqua marked this pull request as draft March 12, 2024 11:58
@eriqua eriqua marked this pull request as ready for review March 12, 2024 14:36
@eriqua eriqua enabled auto-merge (squash) March 12, 2024 14:36
@eriqua eriqua changed the title fix: web/static-site update to enforce publish with source fix: web/static-site workflow fix & update to enforce publish with source Mar 12, 2024
@eriqua eriqua added the Bug Fix label Mar 12, 2024
@eriqua eriqua merged commit e0a236e into main Mar 12, 2024
21 checks passed
@eriqua eriqua deleted the fix/eriqua/static-site branch March 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants