Skip to content

Commit

Permalink
fix: web/static-site update to enforce publish with source (#1253)
Browse files Browse the repository at this point in the history
## Description

- Update template to enforce publish with source
- Fix bug in workflow trigger
- Update identity variable to fix Warning BCP036 thrown by compile

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.web.static-site](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.web.static-site.yml/badge.svg?branch=fix%2Feriqua%2Fstatic-site)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.web.static-site.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [ ] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
eriqua authored Mar 12, 2024
1 parent 524a1b8 commit e0a236e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/avm.res.web.static-site.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ on:
- ".github/actions/templates/avm-**"
- ".github/workflows/avm.template.module.yml"
- ".github/workflows/avm.res.web.static-site.yml"
- "avm/res/web/serverfarm/**"
- "avm/res/web/static-site/**"
- "avm/utilities/pipelines/**"
- "!*/**/README.md"

Expand Down
8 changes: 4 additions & 4 deletions avm/res/web/static-site/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ module staticSite 'br/public:avm/res/web/static-site:<version>' = {

| Parameter | Type | Description |
| :-- | :-- | :-- |
| [`name`](#parameter-name) | string | Name of the static site. |
| [`name`](#parameter-name) | string | The name of the static site. |

**Optional parameters**

Expand All @@ -460,14 +460,14 @@ module staticSite 'br/public:avm/res/web/static-site:<version>' = {
| [`repositoryToken`](#parameter-repositorytoken) | securestring | The Personal Access Token for accessing the GitHub repository. |
| [`repositoryUrl`](#parameter-repositoryurl) | string | The name of the GitHub repository. |
| [`roleAssignments`](#parameter-roleassignments) | array | Array of role assignments to create. |
| [`sku`](#parameter-sku) | string | Type of static site to deploy. |
| [`sku`](#parameter-sku) | string | The service tier and name of the resource SKU. |
| [`stagingEnvironmentPolicy`](#parameter-stagingenvironmentpolicy) | string | State indicating whether staging environments are allowed or not allowed for a static web app. |
| [`tags`](#parameter-tags) | object | Tags of the resource. |
| [`templateProperties`](#parameter-templateproperties) | object | Template Options for the static site. |

### Parameter: `name`

Name of the static site.
The name of the static site.

- Required: Yes
- Type: string
Expand Down Expand Up @@ -1063,7 +1063,7 @@ The principal type of the assigned principal ID.

### Parameter: `sku`

Type of static site to deploy.
The service tier and name of the resource SKU.

- Required: No
- Type: string
Expand Down
4 changes: 2 additions & 2 deletions avm/res/web/static-site/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ metadata name = 'Static Web Apps'
metadata description = 'This module deploys a Static Web App.'
metadata owner = 'Azure/module-maintainers'

@description('Required. Name of the static site.')
@description('Required. The name of the static site.')
@minLength(1)
@maxLength(40)
param name string
Expand All @@ -11,7 +11,7 @@ param name string
'Free'
'Standard'
])
@description('Optional. Type of static site to deploy.')
@description('Optional. The service tier and name of the resource SKU.')
param sku string = 'Free'

@description('Optional. False if config file is locked for this static web app; otherwise, true.')
Expand Down
6 changes: 3 additions & 3 deletions avm/res/web/static-site/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.25.53.49325",
"templateHash": "15307408528388407015"
"templateHash": "18245734514085730321"
},
"name": "Static Web Apps",
"description": "This module deploys a Static Web App.",
Expand Down Expand Up @@ -317,7 +317,7 @@
"minLength": 1,
"maxLength": 40,
"metadata": {
"description": "Required. Name of the static site."
"description": "Required. The name of the static site."
}
},
"sku": {
Expand All @@ -328,7 +328,7 @@
"Standard"
],
"metadata": {
"description": "Optional. Type of static site to deploy."
"description": "Optional. The service tier and name of the resource SKU."
}
},
"allowConfigFileUpdates": {
Expand Down

0 comments on commit e0a236e

Please sign in to comment.