Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a comment to the PR when there are any changes that would change what's cached on windows VHDs #5994

Merged
merged 44 commits into from
Mar 6, 2025
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
359afaf
add lists
timmy-wright Mar 6, 2025
fe0ee7e
fix bug in script
timmy-wright Mar 6, 2025
e7a1f5f
add github pipeline
timmy-wright Mar 6, 2025
25515f7
import module
timmy-wright Mar 6, 2025
8f01c25
slashes
timmy-wright Mar 6, 2025
acab0a9
switch to pwsh
timmy-wright Mar 6, 2025
5a314f7
tweaks
timmy-wright Mar 6, 2025
c9ca145
tweaks
timmy-wright Mar 6, 2025
515ae18
script no exist in master
timmy-wright Mar 6, 2025
4e21cb9
fixes
timmy-wright Mar 6, 2025
ed8fff0
tweak
timmy-wright Mar 6, 2025
f195e19
use git diff
timmy-wright Mar 6, 2025
bd5eafb
set git config
timmy-wright Mar 6, 2025
06d1cfb
set git config
timmy-wright Mar 6, 2025
f067e70
set git config
timmy-wright Mar 6, 2025
fdd6aa1
add diff as comment
timmy-wright Mar 6, 2025
89da4da
cd
timmy-wright Mar 6, 2025
19912da
clean up cd
timmy-wright Mar 6, 2025
4ccbc40
echo diff
timmy-wright Mar 6, 2025
5b4b4ab
echo diff
timmy-wright Mar 6, 2025
4d44283
path
timmy-wright Mar 6, 2025
39c2f9d
fix directory
timmy-wright Mar 6, 2025
f24f41f
upload
timmy-wright Mar 6, 2025
78d2c30
file
timmy-wright Mar 6, 2025
f0e75eb
mkdir -p
timmy-wright Mar 6, 2025
15523c1
mkdir -p
timmy-wright Mar 6, 2025
6049b7f
md file
timmy-wright Mar 6, 2025
6a6cbd3
quotes
timmy-wright Mar 6, 2025
e9db2d2
space
timmy-wright Mar 6, 2025
166408e
have as list
timmy-wright Mar 6, 2025
b8108da
whitespace
timmy-wright Mar 6, 2025
c1d5abe
better test of sorting
timmy-wright Mar 6, 2025
0fe2e2c
add reg key to list
timmy-wright Mar 6, 2025
4da4caa
use right helpers file
timmy-wright Mar 6, 2025
1420d23
grant permissions
timmy-wright Mar 6, 2025
72a0891
echo diff content
timmy-wright Mar 6, 2025
e42d560
append
timmy-wright Mar 6, 2025
8929974
change components.json to see diff
timmy-wright Mar 6, 2025
35b0277
revert components.json
timmy-wright Mar 6, 2025
e8a5381
add comment for no diff
timmy-wright Mar 6, 2025
6b98cee
change components for testing
timmy-wright Mar 6, 2025
cc68a77
revert change components for testing
timmy-wright Mar 6, 2025
b134404
update text
timmy-wright Mar 6, 2025
61994ab
remove unnecessary steps
timmy-wright Mar 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
script no exist in master
timmy-wright committed Mar 6, 2025

Verified

This commit was signed with the committer’s verified signature.
timmy-wright Tim Wright
commit 515ae18a2d81b1b7c4f6fece36bdda6c987ba210
11 changes: 4 additions & 7 deletions .github/workflows/validate-windows-ut.yml
Original file line number Diff line number Diff line change
@@ -46,19 +46,16 @@ jobs:
mkdir win_files
mkdir win_files/master
mkdir win_files/pr
dir
cd master
dir vhdbuilder/scripts/windows/
pwsh -c vhdbuilder/scripts/windows/generate_cached_stuff_list.ps1 ../win_files/master
cd pr
pwsh -c vhdbuilder/scripts/windows/generate_cached_stuff_list.ps1 ../win_files/master master/vhdbuilder/packer/windows/components_json_helpers.ps1 master/vhdbuilder/packer/windows/windows_settings.json master/parts/common/components.json
- name: Produce vhd files - pr
shell: pwsh
run: |
dir
cd pr
dir vhdbuilder/scripts/windows/
pwsh -c vhdbuilder/scripts/windows/generate_cached_stuff_list.ps1 ../win_files/pr
pwsh -c vhdbuilder/scripts/windows/generate_cached_stuff_list.ps1 ../win_files/pr pr/vhdbuilder/packer/windows/components_json_helpers.ps1 pr/vhdbuilder/packer/windows/windows_settings.json pr/parts/common/components.json
- name: diff
shell: pwsh