Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a comment to the PR when there are any changes that would change what's cached on windows VHDs #5994

Merged
merged 44 commits into from
Mar 6, 2025

Conversation

timmy-wright
Copy link
Contributor

@timmy-wright timmy-wright commented Mar 6, 2025

/kind feature

What this PR does / why we need it:

makes a list of all components required on each windows VHD and then makes a diff between master branch and the PR branch, and adds it as a comment on the PR:

image

When there are no changes to windows VHDs:

image

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@timmy-wright timmy-wright marked this pull request as ready for review March 6, 2025 02:55
@timmy-wright timmy-wright changed the title draft: add list of what is cached on each VHD feature: add a comment to the PR when there are any changes that would change what's cached on windows VHDs Mar 6, 2025
Copy link
Member

@bravebeaver bravebeaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmy-wright timmy-wright merged commit 3971cc2 into master Mar 6, 2025
26 checks passed
@timmy-wright timmy-wright deleted the timmy/make-list-of-what-is-on-each-windows-vhd branch March 6, 2025 04:37
suyadav1 pushed a commit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants