-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add a comment to the PR when there are any changes that would change what's cached on windows VHDs #5994
Merged
timmy-wright
merged 44 commits into
master
from
timmy/make-list-of-what-is-on-each-windows-vhd
Mar 6, 2025
Merged
feature: add a comment to the PR when there are any changes that would change what's cached on windows VHDs #5994
timmy-wright
merged 44 commits into
master
from
timmy/make-list-of-what-is-on-each-windows-vhd
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bravebeaver
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
suyadav1
pushed a commit
that referenced
this pull request
Mar 11, 2025
…d change what's cached on windows VHDs (#5994)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
makes a list of all components required on each windows VHD and then makes a diff between master branch and the PR branch, and adds it as a comment on the PR:
When there are no changes to windows VHDs:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: