Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: Fix MAV_CMD_NAV_LOITER_TURNS with zero turns skipping waypoint location #28614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joshanne
Copy link
Contributor

@joshanne joshanne commented Nov 14, 2024

In the case where MAV_CMD_NAV_LOITER_TURNS waypoint is used the AV can skip travelling to the waypoint and jump directly to the next waypoint (if the conditions are correct).

This ensures loiter turns cannot be verified as complete until both loiter target is reached and turn count is met (the latter half is unchanged).

First commit shows the issue occurring, and is an example use case where you might use 0-turn loiters.
Second commit shows the fix to the issue.

Before After
image image

@joshanne
Copy link
Contributor Author

@peterbarker @tridge I suspect a similar issue of short circuiting a waypoint can occur with LOITER_TO_ALT, given it is not checking for reaching of the loiter target either.

@joshanne joshanne requested review from tridge and peterbarker and removed request for tridge November 14, 2024 01:41
@joshanne
Copy link
Contributor Author

@peterbarker @tridge I suspect a similar issue of short circuiting a waypoint can occur with LOITER_TO_ALT, given it is not checking for reaching of the loiter target either.

Although, i haven't been able to prove this through a separate autotest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant