⬆️ Update switch.js

[josemigallas]

TL;DR

This long description is for the sake of describing why this script exists. The PR is pretty straightforward.

Full description

Part of

• THREESCALE-10943: Clean up javascripts assets
• THREESCALE-9982: Unify jquery across 3scale

Switch is a custom component that uses jQuery. It's used both in admin portal and developer portal, but only the admin portal uses jQuery 1.

Admin portal

Used in Application show page, in API Credentials and Referrer filters. The switch shows/hides the "add button" and the "limit warning" alternatively:

Dev Portal

Same usage, different origins. Depending on how long ago the dev portal was created, it uses switch from either:

• 3scale.js
• 3scale-v2.js or
• essential_assets

These are basically copy-pasta files with a collection of scripts from app/assets/javascripts that are used in dev portal:

porta/lib/developer_portal/app/views/developer_portal/javascripts/3scale_v2.js

Lines 498 to 515 in 5749f2d

	(function($) {
	// ever heard about a toggle() function of jQuery?
	$.fn.enableSwitch = function() {
	var context = this;
	context.find(".disabled_block").fadeOut(function() {
	context.find(".enabled_block").fadeIn();
	})
	}
	$.fn.disableSwitch = function() {
	var context = this;
	context.find(".enabled_block").fadeOut(function() {
	context.find(".disabled_block").fadeIn();
	})
	}
	})(jQuery);

⚠️ In order to maintain backwards compatibility with older portals, switch.js has been moved to lib/developer_portal/app/assets/javascripts/switch.js to be loaded in essential_assets.

[mayorova]

I guess this is removed because it is redundant?

porta/app/views/applications/access_details/show.html.erb

Lines 4 to 5 in c44891a

	<% if @cinstance.service.backend_version == "2" %>
	<%= render 'applications/applications/api_credentials', :cinstance => @cinstance %>

[josemigallas]

Correct

[jlledom]

I tried the the key section in the Application screen:

• Removing keys works fine
• Adding a key , random or manually, shows a JS error, but the key is added correctly. You need to refresh the screen to see it.
• Referrer filter works fine

[jlledom]

Then, where did you get this cukes from? Were they somewhere else?

[jlledom]

Can cukes be fixed?