Remove switch_helper and remove obsolete templates

[mayorova]

Removing switch_helper because we really can live without it.

Regardinglib/developer_portal/app/views/developer_portal/admin/applications/referrer_filters/_widget.html.erb and lib/developer_portal/app/views/developer_portal/admin/applications/referrer_filters/_help.html.erb removal, it was quite tricky to follow the history of the developer portal's Application Show template, because it moved so many times within the repository, but I am pretty confident that it actually never relied on the widget partial, and the presense of it is just a result of copy-paste the templates when the ancients splitted the admin and developer portal templates.

I believe that this template has used the following content since the beginning of time:
https://github.com/3scale/system/pull/2536/files#diff-3c9dd32a92e0229e1d80def94ead471afb71a3b0896880e438587a2dd1962381

(look for vendor/developer_portal/.default-templates/applications/show.html.liquid)

It uses this block with explicit class names:

        {% if application.can.add_referrer_filters? %}
          <div class="enabled_block">
          ...
          </div>
        {% else %}
          <div class="disabled_block">
          ...
          </div>
        {% endif %}

and is not using referrer_filters/widget unlike the provider side, and so it was not using the switch_helper either (probably it can't because its Liquid).

[jlledom]

What's the relation between this and #4017? Aren't they incompatible?

[mayorova]

What's the relation between this and #4017? Aren't they incompatible?

Well, this was a suggestion for #4017 branch that was partially applied by @josemigallas

Now I could probably rebase it so some extra suggestions are compatible 😬

[mayorova]

We could keep .enabled_block/ .disabled_block here, but I thought more explicit names were better.

[jlledom]

This works fine for me. If the package is indeed not needed, I vote for removing.

[jlledom]

Was this not being used?

[jlledom]

Same, Was this not being used?

[mayorova]

Yeah, in the PR description I mentioned why I think this file is here. I can't see it being used anywhere, and I think it was not used in the older portals either.

And I think _help has never been used either (for the dev portal).

[jlledom]

in the PR description I mentioned why I think this file is here

Ah right, sorry 😥