Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intra document navigation #1090

Merged
merged 5 commits into from
Mar 21, 2025

Conversation

mvasilak
Copy link
Contributor

Fixes #1088

@mvasilak mvasilak requested a review from michalrentka March 14, 2025 15:24
Copy link
Contributor

@michalrentka michalrentka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the forward button appears and immediately disappears when I tap "back".

ScreenRecording_03-17-2025.10-00-12_1.MP4

@mvasilak
Copy link
Contributor Author

Also the forward button appears and immediately disappears when I tap "back".

This seems to happen internally in PSPDFKit, that is, as the pages scroll, sometimes you get two back forward list delegate callbacks, one that adds the forward button, and another that removes it. I'd suggest that we improve it, and if need be open a PSPDFKit support ticket, as a separate issue.

@michalrentka
Copy link
Contributor

Also the forward button appears and immediately disappears when I tap "back".

This seems to happen internally in PSPDFKit, that is, as the pages scroll, sometimes you get two back forward list delegate callbacks, one that adds the forward button, and another that removes it. I'd suggest that we improve it, and if need be open a PSPDFKit support ticket, as a separate issue.

If you can just keep it visible and it works then great. If it'll look like this I'd rather just keep it hidden until it's fixed.

@mvasilak
Copy link
Contributor Author

@michalrentka ready for another look.

9566629 should fix the forward button flickering issue, as well as the navigation logic in general. This is due to a PSDFKit issue, I'll also report it to them.

@mvasilak mvasilak requested a review from michalrentka March 19, 2025 08:43
@mvasilak
Copy link
Contributor Author

Issue also reported to Nutrient, and recognized as such. We'll remove our fix when they fix it on their side.

@mvasilak mvasilak merged commit d0aac7a into zotero:master Mar 21, 2025
1 check passed
@mvasilak mvasilak deleted the improve-intra-document-navigation branch March 21, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PDF Forward/Back buttons overlap annotation toolbar
2 participants