Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a worker that simulates a long running Sidekiq job #4428

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Jan 29, 2025

Our Sidekiq workers are very fast and rate limitedin a few ways, mostly by the congestion middleware. Makes it kind of hard to test scaling when the jobs complete instantly or are deduplicated and canceled on the way in.

This PR adds an unexposed job that does nothing but sleep for the specified duration. This will facilitate testing (via the console) of scaling systems that use the redis queue length as the determining factor.

Might keep this after if it proves useful in other ways, or I can revert/remove after testing.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@zwolf zwolf merged commit 3806951 into master Feb 5, 2025
8 checks passed
@zwolf zwolf deleted the add-longjob-simulator branch February 5, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants