Fix silent zig fmt errors #21948
Merged
Fix silent zig fmt errors #21948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem to be unrelated to this change |
|
Why do you believe the failures are unrelated to this change? That's a quite weird argument to make when all 10 runs failed in the exact same manner as one another, with each one reporting a formatting error in precisely the file you changed. As it is, the code you have written does not obey |
Sorry, wasn't intended to start an argument, I made an honest misreading of the test output. Just trying to help. I've run |
|
Sorry, by "argument" I just meant "point"/"reason" here, I didn't mean for it to be interpreted as an accusation. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zig fmtwould silently fail for paths that didn't exist. This caused me significant confusion when I was trying to format a file but I had a typo in the name - the command looked like it succeeded in the terminal, but the file wasn't changing.The problem was due to using the warn log level for the error - in
.ReleaseSafeand.ReleaseFastbuild modes.warnmessages aren't printed. I think it's fair to use the error level sinceFileNotFounderrors like this causezig fmtto produce a nonzero exit code.