Fix memcpy alias bug in std.compress.lzma #21447
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces memcpy with mem.copyForwards to prevent overlap panic.
The lzma tests never triggered the bug, I assume the inputs are too small so readAllAlloc never calls .read() for less than half of the buffer length, so if needed I attach some compressed input that does (let me know if I should get a minimal input that reproduces the issue and add a test).
compressed.txt
expected.txt