introduce a fully featured version manager #230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Vexu Any thoughts on these changes? |
8 tasks
|
I allowed myself to mention your PR here ! I can remove it from the list if you desire |
Techatrix
force-pushed
the
techatrix/version-manager
branch
2 times, most recently
from
7c6cb52
to
1475806
Compare
|
I'm guessing there is precedence for extensions downloading additional binaries unprompted when installed so I guess that is fine especially since it is from the official source. As long as overriding the path to the Zig binary still works these all seem like good changes. And sorry for taking so long to get to this. |
These changes make ZLS an "invisible" component of the extension after the initial setup. This also removes the `zig.zls.checkForUpdate` command. I am not sure if it even needs to be brought back. I've made sure that no error is reported if no internet connection is available. The last installed ZLS version should be reused. closes #136 because `zig.zls.startRestart` will just enable ZLS instead of complaining
See the TODOs on what needs to be added to the VersionManager fixes #111
Techatrix
force-pushed
the
techatrix/version-manager
branch
from
1475806
to
528a402
Compare
This commit replaces the initial setup with the following mechanism: 1. Check if the "Install Zig" has been previously executed in the active workspace. If so, install that version. 2. If the workspace contains a `.zigversion`, install the given Zig version. 3. If the workspace contains a `build.zig.zon` with a `minimum_zig_version`, install the next available Zig version. 4. Otherwise fallback to the latest tagged release of Zig. Some parts of this are not fully implemented. fixes #111
- add the ability to remove the workspace zig-version - add an option to manually specify the path to Zig - add an option to select Zig from PATH (if available) - display the exact version of nightly - display which versions are already installed on the host machine - make the popup usable without an internet connection
This unfortunately has a large impact on the bundle size: 600kb -> 1.3mb
It is expected to be removed in ZLS 0.14.0
Techatrix
force-pushed
the
techatrix/version-manager
branch
from
528a402
to
64753bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing Zig or ZLS with the extension doesn't properly handle switching between different Zig project.
You have to manually figure out which version to get and install it every time your switch to a project that requires a different Zig version. Same goes for ZLS. The vscode configuration for Zig also can't handle switching between devices (see #111)
Let's stop giving developer the ability to misconfigure their editor.
Version Manager
This is how the extension selects which version of Zig to install:
zig.versionconfig option (can be global or per-workspace)minimum_zig_versionin thebuild.zigof your workspace.zigversionto your workspace which stores the desired Zig versionIf none of the above apply, the latest tagged release of Zig is installed.
Installs are automatically uninstalled to not fill up disk storage too much.
Installs are verified with minisign
The version of ZLS is inferred from the Zig version.
Status Bar
Hovering over the "Editor Language Status" will show whether Zig and ZLS are installed + their versions. The Status Bar Item for Zig will turn red if is not installed. Clicking on it will open the 'Select and Install' popup.
Updated 'Select and Install' popup
Remaining issues
build.zig.zonis not working properly. see this TODO.zig.checkForUpdateconfig option and update command have been removed. It should be added back but with some adjustments.I wanted to keep these changes as small as possible but I couldn't stop myself. 😞
Any feedback would be greatly appreciated.