Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Onboarding #740

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: Onboarding #740

wants to merge 9 commits into from
+71 −38

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Mar 10, 2025 •
edited by Koenkk
Loading

For Koenkk/zigbee2mqtt#26608

Need to figure out a few things:

  • confirm ingress with onboard URL: http://0.0.0.0:8099
  • way to get the proper ingress URL for display/redirect on onboard confirm (or add bypass ENV in Z2M PR to not display URL/redirect if not possible)
  • actual tests
  • docs

NOTE: currently onboard server is disabled by default (needs further testing in HA add-on specific context).

@Nerivec Nerivec mentioned this pull request Mar 10, 2025
Merged
11 tasks
@Nerivec Nerivec marked this pull request as ready for review March 21, 2025 01:13
@Nerivec

This comment was marked as outdated.

Sign in to view
@Koenkk Koenkk mentioned this pull request Mar 21, 2025
Merged
@Koenkk
Copy link
Contributor

Koenkk commented Mar 25, 2025

Works now! I will hold this PR until the 1 April release since the README refers to the onboarding feature which is not in a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerivec @Koenkk