fix(e2e): only write address book once #3577
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe pull request updates the startup script in Changes
Sequence Diagram(s)sequenceDiagram
participant S as Script (start-zetaclientd.sh)
participant FS as File System
participant CMD as zetae2e Command
S->>FS: Check for address_book.seed file
alt File exists
S->>S: Skip seed file generation
else File does not exist
S->>CMD: Execute "zetae2e local get-zetaclient-bootstrap"
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
contrib/localnet/scripts/start-zetaclientd.sh(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.sh`: Review the shell scripts, point out issues relati...
**/*.sh: Review the shell scripts, point out issues relative to security, performance, and maintainability.
contrib/localnet/scripts/start-zetaclientd.sh
🪛 Shellcheck (0.10.0)
contrib/localnet/scripts/start-zetaclientd.sh
[warning] 73-73: addresss_book_path is referenced but not assigned (did you mean 'address_book_path'?).
(SC2154)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-zetanode
- GitHub Check: lint
- GitHub Check: build-and-test
- GitHub Check: gosec
- GitHub Check: build
- GitHub Check: Analyze (go)
gartnera
force-pushed
the
e2e-zetaclient-bootstrap-once
branch
from
f3b401a to
a981881
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3577 +/- ##
===========================================
+ Coverage 64.72% 64.80% +0.07%
===========================================
Files 461 462 +1
Lines 31894 31934 +40
===========================================
+ Hits 20644 20694 +50
+ Misses 10345 10332 -13
- Partials 905 908 +3 |
gartnera
changed the title
When running in persistent mode, we shouldn't try to write out the address book file a second time. When you restart the container, the other zetaclient containers may not be up yet and the dns resolution performed by this command may fail.
Summary by CodeRabbit