[#3144] : Remove legacyTheme #3191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
geodem127
requested review from
agalin920,
finnar-bin and
shrunyan
and removed request for
agalin920,
finnar-bin and
shrunyan
geodem127
commented
Feb 10, 2025
finnar-bin
requested changes
Feb 10, 2025
geodem127
force-pushed
the
feature/3144-Remove-legacyTheme-updated
branch
3 times, most recently
from
9de916a to
5a5345b
Compare
geodem127
force-pushed
the
feature/3144-Remove-legacyTheme-updated
branch
5 times, most recently
from
0f0663c to
b4a472a
Compare
finnar-bin
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Also, I've noticed that there seems to have been a lot of changes that seem to be enhancements already. I am under the impression that this ticket was supposed to only remove the legacy theme provider? cc @agalin920
src/apps/code-editor/src/app/components/FileDrawer/FileDrawer.js
Outdated
Show resolved
Hide resolved
src/apps/code-editor/src/app/components/FileDrawer/components/FileStatus/FileCopyZuid.js
Outdated
Show resolved
Hide resolved
src/apps/code-editor/src/app/components/FileDrawer/components/FileStatus/FileCopyZuid.js
Outdated
Show resolved
Hide resolved
src/apps/code-editor/src/app/components/FileDrawer/components/FileStatus/FileCopyZuid.js
Outdated
Show resolved
Hide resolved
src/apps/seo/src/views/RedirectsManager/RedirectsTable/RedirectCreator/RedirectCreator.js
Outdated
Show resolved
Hide resolved
geodem127
force-pushed
the
feature/3144-Remove-legacyTheme-updated
branch
from
b4a472a to
0b3584a
Compare
geodem127
force-pushed
the
feature/3144-Remove-legacyTheme-updated
branch
from
ed436fe to
095185b
Compare
geodem127
force-pushed
the
feature/3144-Remove-legacyTheme-updated
branch
from
095185b to
a03a616
Compare
finnar-bin
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
I suggest also having @agalin920 run through this PR to ensure that it's throughly reviewed given how big the change is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.