Problem: want to install additional config files #835
Conversation
Solution: use combination of output to clear the file + append
Solution: add config type to install model
Solution: document it
Solution: create builds/zinstall directory first
| @@ -22,6 +22,7 @@ function zinstall_include (filename) | |||
| endif | |||
| endfunction | |||
|
|
|||
| directory.create ("builds/zinstall") | |||
There was a problem hiding this comment.
Should only be created if zinstall is used!
There was a problem hiding this comment.
I tried the simplest way how to do it
project.has_install = (count (main, (count (main.install) > 0)) > 0)
but it crashes gsl. I'll create minimal reproducer and add issue for imatix/gsl.
imatix/gsl#141
Can we solve it in another PR, please?
There was a problem hiding this comment.
A simple solution might be:
for project.main where defined (main->install)
if !file.exists ("builds/zinstall")
directory.create ("builds/zinstall")
endif
...
|
I'm not sure this problem is valid. Configuration files should never be part of the project itself! What are those configuration files? |
|
@vyskocilm do you have an example project? |
|
@sappo https://github.com/42ity/fty-metric-composite/blob/master/src/fty-metric-composite.cfg.example The example configuration is treated as a template for various instances of other services. so you then have [email protected], [email protected] and so... I can change it for type="datadir", installation of additional data files should be harmless. Makes a sense? |
|
I guess this installation of configuration files refers to sample configs
and/or those generated from templates (like autotools .in support) during
build for a particular distribution with particular FS layout (if that is
involved/specified in the config file), user account names etc. - things
that are not hardcoded in project sources and imposed on all distros, but
that can well be automated to simplify secure setup and working out of the
box on the final system.
2017-01-12 11:01 GMT+01:00 Kevin Sapper <[email protected]>:
… @vyskocilm <https://github.com/vyskocilm> do you have an example project?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#835 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABj5lDTIMJjS7BDg66L0lc08fGojMchCks5rRfntgaJpZM4LhjoA>
.
|
|
I understand the problem, still I think a user wont get the model. But lacking any better ideas I'll merge it for now. |
|
@vyskocilm #834 might be a cleaner solution. |
Solution: add type="config" to zproject_install.gsl