default target Windows version of Python itself #1475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
set-min-win
branch
2 times, most recently
from
5168dd9
to
5700cef
Compare
inherit Py_WIN_VER by default unless specified in extra macros need to always load pyversion_compat for this to work
minrk
force-pushed
the
set-min-win
branch
2 times, most recently
from
9e8a529
to
3352a37
Compare
we don't have source control over libzmq itself to add includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inherits Py_WIN_VER from pyconfig.h by default unless specified in extra macros
Setting WIN_VER sets our target Windows version as recommended here.
Further discussion of WIN_VER in MS docs
should close #1472