Modules #978
Merged
Modules #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the assembly description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using multi-modules for jeromq, so it allows the generation of a multi-release jar.
The setup is not easy because it must comply with the following contraints:
— Compatible with IDE, so each module must handle only one Java version.
— Generate usable javadoc and sources artifacts.
— Keep usefull artifact names and dependency.
The current organisation is the only one I found that match all of them. But there is still to problems to handles:
— Missing the META-INF/maven in the generated sources jar.
— Some MANIFEST properties for OSGi needs to be manually managed.
Once handled, PR #967 can be updated and merged.