Added diagnosis for metrics test failures #568

zeroc-ice · Oct 14, 2019 · 4211b55 · 4211b55
1 parent 68a22e2
commit 4211b55
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/cpp/test/Ice/metrics/AllTests.cpp b/cpp/test/Ice/metrics/AllTests.cpp
@@ -1325,9 +1325,18 @@ allTests(Test::TestHelper* helper, const CommunicatorObserverIPtr& obsv)
         im1 = ICE_DYNAMIC_CAST(IceMX::InvocationMetrics, map["fail"]);
         test(im1->current <= 1 && im1->total == 3 && im1->failures == 3 && im1->retry == 3 && im1->remotes.size() == 1);
         rim1 = ICE_DYNAMIC_CAST(IceMX::ChildInvocationMetrics, im1->remotes[0]);
-        test(rim1->current == 0);
-        test(rim1->total == 6);
-        test(rim1->failures == 6);
+        if(rim1->current != 0 || rim1->total != 6 || rim1->failures != 6)
+        {
+            cerr << "rim1->current = " << rim1->current << endl;
+            cerr << "rim1->total = " << rim1->total << endl;
+            cerr << "rim1->failures = " << rim1->failures << endl;
+            IceMX::MetricsFailures f = clientMetrics->getMetricsFailures("View", "Invocation", im1->id);
+            for(IceMX::StringIntDict::const_iterator p = f.failures.begin(); p != f.failures.end(); ++p)
+            {
+                cerr << p->first << " = " << p->second << endl;
+            }
+        }
+        test(rim1->current == 0 && rim1->total == 6 && rim1->failures == 6);
         checkFailure(clientMetrics, "Invocation", im1->id, "::Ice::ConnectionLostException", 3);
     }
 

diff --git a/objective-c/test/Ice/metrics/AllTests.m b/objective-c/test/Ice/metrics/AllTests.m
@@ -1079,9 +1079,18 @@ -(void) run
     im1 = (ICEMXInvocationMetrics*)[map objectForKey:@"fail"];
     test(im1.current <= 1 && im1.total == 3 && im1.failures == 3 && im1.retry == 3 && [im1.remotes count] == 1);
     rim1 = (ICEMXRemoteMetrics*)[im1.remotes objectAtIndex:0];
-    test(rim1.current == 0);
-    test(rim1.total == 6);
-    test(rim1.failures == 6);
+    if(rim1.current != 0 || rim1.total != 6 || rim1.failures != 6)
+    {
+        tprintf("rim1->current = %d\n", rim1.current);
+        tprintf("rim1->total = %d\n", rim1.total);
+        tprintf("rim1->failures = %d\n", rim1.failures);
+        ICEMXMetricsFailures* f = [clientMetrics getMetricsFailures:@"View" map:@"Invocation" id:im1.id_];
+        for(NSString* key in f.failures)
+        {
+            tprintf("%@ = %@", key, [f.failures objectForKey:key]);
+        }
+    }
+    test(rim1.current == 0 && rim1.total == 6 && rim1.failures == 6);
 
     checkFailure(clientMetrics, @"Invocation", im1.id_, @"::Ice::ConnectionLostException", 3);