Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add console harness to check log message in sample.usbd.dfu test #86362

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Add console harness to check log message in sample.usbd.dfu test #86362

merged 1 commit into from
Mar 4, 2025

Conversation

marwaiehm-st
Copy link
Collaborator

@marwaiehm-st marwaiehm-st commented Feb 26, 2025 •
edited by jfischer-no
Loading

  • Added harness configuration to the sample.usbd.dfu test to avoid failing results on the bench report.
  • Configured the console harness with a one_line type and a regex pattern to match the "USB DFU sample is initialized" log message.
  • Ensures the test passes if the expected log message is found in the console output.

Fixes: #85314

@marwaiehm-st marwaiehm-st marked this pull request as ready for review February 27, 2025 08:51
@marwaiehm-st marwaiehm-st changed the title Add console harness to check log message in sample.usbd.dfu-flash test Add console harness to check log message in sample.usbd.dfu test Feb 27, 2025
@zephyrbot zephyrbot added area: Samples Samples area: USB Universal Serial Bus labels Feb 27, 2025
jfischer-no
jfischer-no requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marwaiehm-st You need to work on your commit messages.

samples: usb: dfu-next: make the sample testable

Add a console harness to check that the example has
started successfully.

@marwaiehm-st
samples: usb: dfu-next: make the sample testable
ffac506 
Add a console harness to check that the example has
started successfully.

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
@katgiadla katgiadla mentioned this pull request Feb 28, 2025
Closed
katgiadla
katgiadla approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@katgiadla katgiadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfischer-no jfischer-no added bug The issue is a bug, or the PR is fixing a bug Experimental Experimental features not enabled by default labels Feb 28, 2025
@jfischer-no jfischer-no added this to the v4.1.0 milestone Feb 28, 2025
@fabiobaltieri fabiobaltieri merged commit 1a12889 into zephyrproject-rtos:main Mar 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@katgiadla katgiadla katgiadla approved these changes

@nashif nashif Awaiting requested review from nashif

@tmon-nordic tmon-nordic Awaiting requested review from tmon-nordic

Assignees

@kartben kartben

Labels
area: Samples Samples area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug Experimental Experimental features not enabled by default
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

samples: subsys: usb: dfu-next: sample.usbd.dfu{-flash} report timeout
6 participants
@marwaiehm-st @kartben @jfischer-no @katgiadla @fabiobaltieri @zephyrbot