-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Quill Dependency to 2.0.0-rc.4 #967
base: master
Are you sure you want to change the base?
Conversation
You forgot to update the yarn lock file. Also, Quill 2.0.0-rc.5 is out, so might as well bump it. Do note that 2 other PRs have been created in the last few years attempting this same upgrade, but neither were merged: #507 and #711. It's also worth noting that QuillJS v1.3.7 relies on the browser mutation events, which is deprecated and will be removed from Chrome in July 2024. This means The last time we heard from one of the maintainers of react-quill regarding this was in November of 2023: #914 (comment) |
It looks like Quill 2.0 has been officially released. |
Sources, | ||
} from 'quill'; | ||
import Quill, { QuillOptions as QuillOptionsStatic } from 'quill'; | ||
import type { EmitterSource as Sources } from 'quill/core/emitter'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: EmitterSource
can be imported directly from quill
:
import type { EmitterSource } from 'quill';
The same applies to Range
:
import type { Range } from 'quill';
Hello. Any updates on when this will be merged? Would like to address the DomNodeInserted deprecation message.. |
Hey there, when will this get merged ? |
I would like to know as well. |
My (limited) understanding is that this would include the same breaking changes for react-quill user's as detailed on https://quilljs.com/docs/upgrading-to-2-0 right? If so, it would probably be wise to add a call-out in the readme && changelog to the relevant document |
This PR updates the
quill
dependency inreact-quill
from an outdated version (1.3.7
) to the latest release candidate,2.0.0-rc.4
. The previous major version of Quill has not been updated for over five years and includes several security vulnerabilities that have been resolved in version 2.0.Key Changes
The upgrade to Quill 2.0.0-rc.4 addresses critical security concerns, ensuring a safer and more reliable library for our users.
By staying current with Quill's latest versions, we ensure compatibility with future updates and maintain the robustness of react-quill.