Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lerna-changelog): dynamic ESM import #181

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix(lerna-changelog): dynamic ESM import #181

merged 1 commit into from
Aug 14, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Aug 14, 2023

Description

Per rules of ESM, need to provide the .js extension, otherwise import errors out.

Detail

Had tested this command for #180, but didn't get through a full execution until attempting yarn run tag on react-components 😬

@jzempel jzempel requested a review from a team as a code owner August 14, 2023 15:54
@jzempel jzempel merged commit d3048af into main Aug 14, 2023
@jzempel jzempel deleted the jzempel/fix-esm branch August 14, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants