fix(theming): nested ColorSchemeProvider
system color scheme handling
#2000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into a gnarly error while attempting to retrofit
ColorSchemeProvider
on to the Garden website along with a new component page and embedded example. Due to React's useEffect cleanup logic the placement of the provider'smediaQuery
listener was being unexpectedly removed from the embedded example. As a result, changing the system color scheme updated the website as expected, but was not cascading to the embedded example.The solution was to move the
useEffect
out of the hook and into theColorSchemeProvider
itself. Doing so ensures mounting/unmounting (and associated listener add/removal) works as expected.