Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdowns.next): active listbox option and menu item styling #1656

Closed
wants to merge 3 commits into from

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Nov 13, 2023

Description

Use box-shadow styling to add a full activation border to:

  • Combobox listbox Option
  • Menu Item

@jzempel
Copy link
Member Author

jzempel commented Nov 13, 2023

@zendesk-garden zendesk-garden requested a deployment to staging November 13, 2023 22:54 Abandoned
@lucijanblagonic
Copy link

@lucijanblagonic here's the corresponding storybook deployment: https://6552a5d810118432ce22c5b5--jzempel.netlify.app/?path=/story/packages-dropdowns-next-combobox--uncontrolled

Since this is an inset focus style, the border should be 2px thick. I was basing the reasoning from the previous focus state styling research we did, including the WCAG 2.2. Is there a reason you pick 1px?

@jzempel
Copy link
Member Author

jzempel commented Nov 14, 2023

Is there a reason you pick 1px?

I was dereferencing the wrong theming value. Here's the updated deployment with 2px activation box-shadow: https://6553aa0855ce51008cb3c865--jzempel.netlify.app/?path=/story/packages-dropdowns-next-combobox--uncontrolled

@zendesk-garden zendesk-garden requested a deployment to staging November 14, 2023 17:32 Abandoned
@jzempel
Copy link
Member Author

jzempel commented Nov 16, 2023

design style rejected

@jzempel jzempel closed this Nov 16, 2023
@jzempel jzempel deleted the jzempel/dropdown-focus-full branch November 16, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants