Improved image upload #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswittich
requested review from
NiklasNeugebauer
and removed request for
NiklasNeugebauer
This reverts commit ca77fce.
…ich is a server side problem!!)
…sts were failing because the loop server was in a bad state
…onditions) typing: fix several type annotations arising from the changes
NiklasNeugebauer
approved these changes
Mar 4, 2025
NOTE: now irrelevant since we have an internal rate limiter
|
PR is done... I will do some smoke tests and wait for the loop PR to get green with this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of new upload strategy.
Basic concept: Hold a list of items to upload which is cut off if it gets to long.
In each update cycle the first BS items are uploaded.
There is a priority queue with images that are not dropped and always uploaded fist.
Fixes an error due to an unclosed clientsession where we forgot to await the response.
BREAKING CHANGE:
The abstract method
evaluatewhich needs to be implemented by detectors now provides the raw jpg image bytes instead of a semi-converted np.array. This means if the detector uses cv2, reading the file can be done withcv_image = cv2.imdecode(np.frombuffer(image, np.uint8), cv2.IMREAD_COLOR). Alternatively PIL could be used as well.