feat: option to disable ears on all skins

[Phoenix616]

User description

This adds an option to toggle whether or not the Deadmau5 ears are rendered for skins. Someone might want to toggle them off if skins include a full background there or information for some other mod. If toggled off the Vanilla logic of checking for Deadmau5's username is used and only their skin renders ears.

---

PR Type

Enhancement

---

Description

• Added a configurable option to toggle Deadmau5 ears rendering.

• Updated logic to conditionally render ears based on configuration.

• Integrated the new renderEars option into the GUI and options storage.

• Adjusted default settings and watchers to support the new feature.

---

Changes walkthrough 📝

	Relevant files
Enhancement	entities.ts Conditional rendering of Deadmau5 ears based on configuration renderer/viewer/lib/entities.ts Added logic to conditionally render Deadmau5 ears based on configuration. Ensured ears rendering is disabled if the canvas is blank. Refactored existing ears rendering logic to support new option. +11/-6    optionsGuiScheme.tsx Integrated `renderEars` option into GUI scheme                      src/optionsGuiScheme.tsx Added renderEars option to GUI scheme. Provided tooltip description for renderEars option. +3/-0      optionsStorage.ts Added `renderEars` to options storage                                        src/optionsStorage.ts Added renderEars to default options storage. Ensured renderEars is included in the options structure. +1/-0      watchOptions.ts Updated watcher to handle `renderEars` configuration          src/watchOptions.ts Updated watcher to apply renderEars configuration dynamically. Ensured renderEars is synchronized with viewer configuration. +1/-0
Configuration changes	worldrendererCommon.ts Added `renderEars` to default configuration                            renderer/viewer/lib/worldrendererCommon.ts Introduced renderEars as a default configuration option. Set default value for renderEars to true. +1/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[qodo-merge-pro-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Memory Leak The earsCanvas element is created but never removed. Consider cleaning up this DOM element when it's no longer needed to prevent memory leaks. earsCanvas = document.createElement('canvas') loadEarsToCanvasFromSkin(earsCanvas, image) Error Handling The loadEarsToCanvasFromSkin function call has no error handling. If the skin image loading fails, it could cause runtime errors. loadEarsToCanvasFromSkin(earsCanvas, image)

[qodo-merge-pro-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add null check for safety The viewer configuration update should be wrapped in a null check to prevent potential runtime errors if the viewer object is undefined. src/watchOptions.ts [99] -viewer.world.config.renderEars = o.renderEars +if (viewer?.world) { + viewer.world.config.renderEars = o.renderEars +} Apply this suggestion Suggestion importance[1-10]: 8 __ Why: The suggestion addresses a potential runtime error by adding a null check for the viewer object, which is a critical safety improvement that could prevent application crashes in edge cases.	Medium
General	Optimize canvas creation logic The renderEars condition should be evaluated after checking if the canvas is blank, not before. The current order creates an unnecessary canvas element when rendering is disabled. renderer/viewer/lib/entities.ts [353-359] let renderEars = this.viewer.world.config.renderEars || username === 'deadmau5' -let earsCanvas -if (renderEars) { - earsCanvas = document.createElement('canvas') - loadEarsToCanvasFromSkin(earsCanvas, image) - renderEars = !isCanvasBlank(earsCanvas) -} +let earsCanvas = document.createElement('canvas') +loadEarsToCanvasFromSkin(earsCanvas, image) +renderEars = renderEars && !isCanvasBlank(earsCanvas) Apply this suggestion Suggestion importance[1-10]: 4 __ Why: While the suggestion would optimize the code by avoiding unnecessary canvas creation, the current implementation is still functional and the optimization gain would be minimal since this operation is not frequently executed.	Low

[zardoy]

conflicts with #261 have to finish that first. added one comment

[zardoy]

oh as i thought now have conflicts:(

[Phoenix616]

oh as i thought now have conflicts:(

Resolved them :)