Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.21.3 and alpine to 3.18 #79

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

neiljain
Copy link
Contributor

@neiljain neiljain commented Oct 7, 2023

  • update versions in earthfile

- Earthfile version is invalid, supported versions are [0.0 0.5 0.6]

Signed-off-by: Neelesh Jain <[email protected]>
@djeebus
Copy link
Collaborator

djeebus commented Oct 10, 2023

I believe you're going to have to bump the golang version in .tool-versions

Signed-off-by: Neelesh Jain <[email protected]>
@neiljain neiljain changed the title Bump golang to 1.21.2 and alpine to 3.18 Bump golang to 1.21.3 and alpine to 3.18 Oct 10, 2023
- its a fork of helm-unittest and no new releases since Jan there

Signed-off-by: Neelesh Jain <[email protected]>
@neiljain
Copy link
Contributor Author

neiljain commented Oct 12, 2023

I pushed a few more commits to resolve previous build failures, can we trigger the workflows again to see if that helps?

@djeebus
Copy link
Collaborator

djeebus commented Oct 12, 2023

While you're upgrading the world, you could swap from quintush/helm-unittest to helm-unittest/helm-unittest, which would let you upgrade it to 0.3.5

@neiljain
Copy link
Contributor Author

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

@djeebus
Copy link
Collaborator

djeebus commented Oct 22, 2023

I've instead reverted helm chart related changes to focus this PR only on golang and alpine updates. Best to look into helm chart unit testing related upgrade separately.

good call. I approved the run, lets see how it goes!

@djeebus
Copy link
Collaborator

djeebus commented Oct 24, 2023

Success, thanks!

@djeebus djeebus merged commit 5047e63 into zapier:main Oct 24, 2023
6 checks passed
@neiljain neiljain deleted the feature/update-golang-1-21 branch October 24, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants