Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module - Load balancer - nolookup #112

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Module - Load balancer - nolookup #112

wants to merge 62 commits into from

Conversation

Jakeasaurus
Copy link
Collaborator

@Jakeasaurus Jakeasaurus commented Jan 2, 2025 •
edited
Loading

Description

New LB module that allows for nlb or alb creation.

Successful run.

Issue or Ticket

Fixes #110

Type of change

  • Bugfix
  • New feature
  • Version update

Breaking Changes

  • Yes
  • No

Breaking Changes Description

  • previous module still exists, but should be removed later.

TODOs

  • Validate your code matches the style of the project.
  • Update the docs.
  • Validate all tests run successfull, including pre-commit checks.
  • Include release notes and description. This should include both a summary of the changes and any necessary context.

@Jakeasaurus Jakeasaurus force-pushed the dev_lb_nolookup branch 2 times, most recently from 413cec3 to 34bbe74 Compare January 3, 2025 16:16
@Jakeasaurus
Copy link
Collaborator Author

Tested branch here:
https://app.terraform.io/app/SLFCU/workspaces/aws_dev_sandbox/runs/run-mkPhf2y1ZZy6G67Y

Then merged changes into this branch and pr with --force

zachreborn
zachreborn requested changes Jan 3, 2025
View reviewed changes
@Jakeasaurus
Copy link
Collaborator Author

Going to merge in my changes from another branch here. The above changes will be in there.

@Jakeasaurus
Copy link
Collaborator Author

@zachreborn ready for review.

We need to take a look at the subnets and the name prefix. other than that I believe it is good. Maybe we can disucss those two items next week.

zachreborn
zachreborn requested changes Jan 29, 2025
View reviewed changes
@Jakeasaurus
Copy link
Collaborator Author

run for success on nlb - https://app.terraform.io/app/SLFCU/workspaces/aws_dev_sandbox/runs/run-Rm1a6dVEQuNz2ybb

@Jakeasaurus
Copy link
Collaborator Author

successful run on alb - https://app.terraform.io/app/SLFCU/workspaces/aws_dev_sandbox/runs/run-NEh9Cx53naZnU32C

@Jakeasaurus
Copy link
Collaborator Author

successful run after the above changes
https://app.terraform.io/app/SLFCU/workspaces/aws_dev_sandbox/runs/run-ACYK4GSsqFi42d93

@Jakeasaurus
Copy link
Collaborator Author

@zachreborn just a bump after the weekend.

zachreborn
zachreborn approved these changes Mar 27, 2025
View reviewed changes
Copy link
Owner

@zachreborn zachreborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

zachreborn
zachreborn requested changes Mar 27, 2025
View reviewed changes
Copy link
Owner

@zachreborn zachreborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to deprecate old LB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachreborn zachreborn zachreborn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module - AWS NLB
2 participants
@Jakeasaurus @zachreborn