Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding angular module #286

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lukasz-karolewski
Copy link

This change would make it easy to use jison in angular projects.

Workflow would look like this:

  • install jison npm package,
  • create grammar
  • create gulp/grunt task to process grammar and generate parser (produces angular factory object)
  • include generated file with angular module
  • inject into your angular controller

deathcap added a commit to deathcap/jison-plus that referenced this pull request Feb 9, 2016
m99coder pushed a commit to m99coder/jison that referenced this pull request Feb 23, 2016
@mluis
Copy link

mluis commented Nov 7, 2018

Any idea how to include Jison in an angular project without this ?

@lukasz-karolewski
Copy link
Author

if your project is in es6 you can just use amd module, import it where you need it, and wrap in angular service for convenience of dependency injection. This PR is from 3 years back... i guess at that time i must have had my angular project in es5 and bundled together with gulp 😂

@mluis
Copy link

mluis commented Nov 8, 2018

At the moment I'm struggling to get this included in Angular 5! I believe this PR would do the trick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants