Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Export PDF produces different HTML than Export HTML. #384 #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lightrabbit
Copy link

This issue #384 is caused by the fact that cheerio automatically adds closing tags for unclosed opening tags. However, when processing HTML fragments with html_block, the input HTML may not always be a complete document.

This leads to situations where:

<div><img src="...">
# some title
some text
</div>

is processed into:

<div><img src="..."></div>
# some title
some text
// Here, the </div> is automatically removed by cheerio.

The issue arises because cheerio assumes that any unclosed tags should be properly closed, which can cause unexpected behavior when working with incomplete HTML fragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant