Drawio - Add resolution of external image to get self contained SVG #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jynolen
changed the title
ggrossetie
reviewed
Aug 15, 2024
Comment on lines
+53
to
+54
| await writeFile("before.svg", svgRoot) | ||
| await writeFile("after.svg", $("svg").toString()) |
There was a problem hiding this comment.
I guess this was for testing purpose?
ggrossetie
reviewed
Aug 15, 2024
| @@ -27,6 +29,32 @@ export class Worker { | |||
| this.convertTimeout = process.env.KROKI_DIAGRAMSNET_CONVERT_TIMEOUT || '15000' | |||
| } | |||
|
|
|||
| async resolveImage(svgRoot) { | |||
| let $ = cheerio.load(svgRoot, { | |||
There was a problem hiding this comment.
Since we are using Puppeteer we could potentially parse/edit the SVG in page.evaluate? That would remove the dependency on cheerio.
There was a problem hiding this comment.
Definitely I am not a JS expert I will check to change it
|
Someone mentioned in the community chat that diagrams.net has an "embed" feature: https://www.drawio.com/doc/faq/embed-mode It might be possible to rely on the query parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR help to keep drawio svg self contained.
Background
I use SelfHosted Kroki with antora doc generator
When using drawio diagrams it happned that some part of the diagr was missing because it relies on external images.
What have been done:
With this PR, during the rendering phase, kroki will retreive external image to embed them as base64 src.
This way diagrram will be rendered correctly whenever and wherever