jqXHR.abort considered harmful #11
Conversation
| this.xhr = false; | ||
| } else { | ||
| // Ignore response from earlier request. | ||
| return; |
There was a problem hiding this comment.
A future improvement here would be to not ignore the response, since it's a valid response. If every XHR gets an increasing ID attached to it and the autocomplete keeps track of the last displayed ID, then results from earlier could be safely displayed to the user as they type. The xhr-pending class would remain on the input until the current request finished, making it clear that the results are not final.
This would be nice behavior in situations where the server response time is longer than xhrWait value. If the server takes 400ms to get a response to the client, and xhrWait is 200ms, then some XHR will be sent while the user is typing and get a response before the most recent request finishes, so it could be displayed as the user types.
|
Sounds great! |
As per the request in #3 for a PR. Avoid using abort unless the jqXHR hasn't been sent to avoid a closed connection (and broken pipe on the server).