-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
super(..) -> super() #165
base: master
Are you sure you want to change the base?
super(..) -> super() #165
Conversation
WalkthroughThe changes update explicit superclass method calls to the concise Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
session_security/tests/test_base.py (1)
38-45
: Inconsistent mixin setup invocation inBaseLiveServerTestCase
:
While the call tosuper().setUp()
at line 44 is updated, the explicit callSettingsMixin.setUp(self)
on line 39 can be refactored for consistency. Replacing it withsuper().setUp()
would leverage the method resolution order better and improve maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
session_security/tests/project/urls.py
(1 hunks)session_security/tests/test_base.py
(3 hunks)session_security/tests/test_middleware.py
(1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
session_security/tests/test_middleware.py (2)
session_security/tests/test_base.py (2)
setUp
(24-30)setUp
(38-50)session_security/tests/test_views.py (1)
setUp
(21-22)
🔇 Additional comments (4)
session_security/tests/test_middleware.py (1)
15-17
: Modernizedsuper()
usage insetUp
method:
The change to usingsuper().setUp()
enhances readability and adheres to modern Python practices.session_security/tests/project/urls.py (1)
20-23
: Simplified superclass call inSleepView.get()
:
Replacing the explicit class reference withsuper().get(request, *args, **kwargs)
makes the code more concise and modern without altering functionality.session_security/tests/test_base.py (2)
23-30
: Modernizedsuper()
usage inSettingsMixin.setUp()
:
Usingsuper().setUp()
here ensures proper chaining in multiple inheritance scenarios and aligns with current best practices.
58-59
: Modernizedsuper()
usage intearDownClass
:
The updated call tosuper().tearDownClass()
appropriately follows modern Python conventions for class method cleanup.
Summary by CodeRabbit