Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename YK_LOG to YKD_LOG. #1586

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Rename YK_LOG to YKD_LOG. #1586

merged 1 commit into from
Feb 7, 2025

Conversation

ltratt
Copy link
Contributor

@ltratt ltratt commented Feb 6, 2025

This is something we expect interpreter authors might need, which is how we defined YKD in the docs:

Variables prefixed with YKD_ are intended to help interpreter
authors debug performance issues.

This is something we expect interpreter authors might need, which is how
we defined `YKD` in the docs:

> Variables prefixed with `YKD_` are intended to help interpreter
> authors debug performance issues.
@vext01
Copy link
Contributor

vext01 commented Feb 6, 2025

yes please!

@ltratt
Copy link
Contributor Author

ltratt commented Feb 6, 2025

Do you want to merge this then?

@vext01 vext01 added this pull request to the merge queue Feb 6, 2025
@vext01
Copy link
Contributor

vext01 commented Feb 6, 2025

Sorry, thought I had.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@ltratt
Copy link
Contributor Author

ltratt commented Feb 6, 2025

Havlak failed this time. Retry?

@vext01 vext01 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@vext01 vext01 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@vext01 vext01 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into ykjit:master with commit 92a2a3e Feb 7, 2025
2 checks passed
@ltratt ltratt deleted the ykd_log branch February 10, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants