Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20332: Added support for the '__class' key in \yii\di\Instance:eunsure(['__class' => ...]) #20332

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

lav45
Copy link
Contributor

@lav45 lav45 commented Feb 25, 2025

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Fixed issues #17720
Instance::ensure(['__class' => 'yii\db\Connection', 'dsn' => '...']);

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (53ce354) to head (285b87f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
framework/di/Instance.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20332   +/-   ##
=========================================
  Coverage     64.85%   64.85%           
- Complexity    11435    11436    +1     
=========================================
  Files           431      431           
  Lines         37193    37198    +5     
=========================================
+ Hits          24120    24124    +4     
- Misses        13073    13074    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark requested review from a team February 25, 2025 16:42
@samdark samdark added this to the 2.0.53 milestone Feb 25, 2025
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add a line for CHANGELOG?

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add a line for CHANGELOG?

@samdark samdark changed the title Fix #17720 for \yii\di\Instance::ensure() Fix #20332: Added support for the '__class' key in \yii\di\Instance:eunsure(['__class' => ...]) Feb 27, 2025
@samdark samdark merged commit dbb82a2 into yiisoft:master Feb 27, 2025
86 of 87 checks passed
@samdark
Copy link
Member

samdark commented Feb 27, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants