fix regression in ArrayHelper::map #20328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
! fix regression in ArrayHelper::map when trying to use magic methods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20328 +/- ##
============================================
- Coverage 64.85% 64.84% -0.01%
+ Complexity 11435 11430 -5
============================================
Files 431 431
Lines 37193 37191 -2
============================================
- Hits 24120 24118 -2
Misses 13073 13073 ☔ View full report in Codecov by Sentry. |
rob006
reviewed
Feb 21, 2025
|
|
||
| public function __isset($name) | ||
| { | ||
| return isset($this->$name); |
There was a problem hiding this comment.
This implementation is incorrect - it returns false for magic and moreMagic properties.
There was a problem hiding this comment.
Thanks for pointing that out - the tests end up succeeding if isset is implemented correctly.
After testing with where I initially noticed the "issue" first, I figured out it's actually another implementation problem on my end 🤦 nevermind this PR and issue lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression in ArrayHelper::map when trying to use magic methods
Also added a test to check for this regression in the future.