exitcode 1 on exception in yii_test #433
Conversation
rumours86
commented
Jul 2, 2019
rumours86
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | yiisoft/yii2-app-basic#180 |
|
Does it change anything? It does not fix #180, since there is no uncaught exception in this case. And in case of uncaught exception PHP should already return non-zero exit code. So what is the point of this change? |
|
If an error occurs during the migration, php does not return a non-zero exit code. In our project we use this code, and it corrects this situation. If an error occurs while applying migrations, the CI build stops. |
|
you confused the issue |
|
but I use the author of the issue ./yii if you think you need to make this correction and in ./yii I can will do it |
| $exitCode = $application->run(); | ||
| try { | ||
| $exitCode = $application->run(); | ||
| } catch (\Exception $exception) { |
There was a problem hiding this comment.
That would cause error handler to never fire preventing logging exceptions and errors. Also that would mess up formatting.
I think what you want to change is https://github.com/yiisoft/yii2/blob/master/framework/base/ErrorHandler.php#L112 but that can't be done since it would affect testing (tests would exit after first failure without suite completion).
|
In this state pull request can't be merged. Another solution should be found. |
