fix: some vulnerabilities #717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian-Schoenherr <[email protected]>
Signed-off-by: Florian-Schoenherr <[email protected]>
Signed-off-by: Florian-Schoenherr <[email protected]>
Signed-off-by: Florian-Schoenherr <[email protected]>
|
oh and I replaced got with node-fetch, which wasn't really necessary here, could be reverted, too. |
mshima
requested changes
Dec 6, 2021
| @@ -17,7 +17,6 @@ | |||
| "scripts": { | |||
| "postinstall": "yodoctor", | |||
| "postupdate": "yodoctor", | |||
| "pretest": "xo", | |||
| @@ -84,7 +82,7 @@ | |||
| "proxyquire": "^2.0.1", | |||
| "registry-url": "^5.1.0", | |||
| "sinon": "^6.1.3", | |||
| "xo": "0.38.0" | |||
| "xo": "^0.47.0" | |||
There was a problem hiding this comment.
Suggested change
| "xo": "^0.47.0" | |
| "xo": "0.38.0" |
There are security problems, but this is dev only, won’t be a problem for npm install yo.
Version 0.40.0 is esm only. So 0.39.x should be to newest possible.
|
@Florian-Schoenherr - could you please merge the changes related to "npm-keyword" & "latest-version". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
What changes did you make?
Fixed some of the security vulnerabilities, the others depend on some of the PRs in sub repos.
Is there anything you'd like reviewers to focus on?
I removed the "pretest": "xo" script for now, as it doesn't work. I think temporarily removing it is better than keeping a high security vulnerability around. This is the error when keeping it:
the cut line says
Cannot find package 'D:\...\yo\node_modules\xo\node_modules\eslint\' imported from D:\...\yo\node_modules\xo\index.js