-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Test refactor (No merge) #763
Open
UlisesGascon
wants to merge
17
commits into
yeoman:main
Choose a base branch
from
UlisesGascon:test-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `--test-framework` argument in the initialization for prompts - Added new responses to global `this` following the current convention
As requested in #0599cc1a6845800bc0063c30b540b7dbc9fdbeb5
- Added test - Added tasks and dependencies to generated project - Added copy tasks to main writing task
- Babel config now supports modules (imp/exp) - Added module support in the index.html - Added sample function in main.js for future unit testing - Tests updated
This reverts commit 0b05190.
- Babel config now supports modules (imp/exp) - Added module support in the index.html - Added sample function in main.js for future unit testing - Tests updated
- Updated generator tests - Improved combined tests behaviour (e2e + unit) as single task - Added Jest sample test based in main.js' greetings function
- Updated generator tests - Added Ava sample test based in main.js' greetings function
😓 Sorry for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, DO NOT merge it!
This is a working in progress feature. See #759
@silvenon... Let me share with you my approach for this feature.
app/scripts/main.js
that exports a simple'\'Allo \'Allo!'
text that is used already in the generator. The idea is to test this text in the several frameworks.What do you think?