Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --yarn option to use yarn instead of npm #293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glensc
Copy link

@glensc glensc commented Mar 22, 2022

Fixes #289

use yarnInstall if --yarn option is used:

@glensc
Copy link
Author

glensc commented Mar 22, 2022

I don't know how to test this without code being published in npm registry.

@glensc glensc mentioned this pull request Mar 22, 2022
@oklas
Copy link

oklas commented Mar 24, 2022

It is possible to install package for testing. Package may be installed from local folder or from tarball, both yarn and npm.

@glensc glensc marked this pull request as draft March 24, 2022 11:11
@glensc
Copy link
Author

glensc commented Mar 24, 2022

Probably more changes needed, as this did not have any effect at all

@oklas
Copy link

oklas commented Mar 24, 2022

Perhaps yes

@oklas
Copy link

oklas commented Mar 25, 2022

Moreover, I do not see similar testing for npm either. But I noticed that the readme template generator should also be changed here

@glensc
Copy link
Author

glensc commented Mar 26, 2022

PR for readme sub-generator:

let's get that resolved and merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using yarn
2 participants